Bug non draft with system user (Issue #242)#250
Open
Andreas-Meindl-msggroup wants to merge 834 commits into
Open
Bug non draft with system user (Issue #242)#250Andreas-Meindl-msggroup wants to merge 834 commits into
Andreas-Meindl-msggroup wants to merge 834 commits into
Conversation
…into containment-error-cds8
Support for non draft scenarios
…d of .docx as .docx file is restricted in test repo
[Hyperspace] 🤖 Add PR Bot Configuration
Fix [NodeJs] Incorrect Warning message if a user without SDM Roles updates custom properties or renames attachments
FIX Setting the custom properties value to null doesn't revert the value in SDM
fix for draft edit link
Edit link automation
Change Log for Release 1.9.0 & an error message fix in Integration test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Creating attachments does not work for technical system users.
In our use case, non-draft attachments are created from a technical system user and not triggered by an UI action.
This causes error
"Could not fetch JWT bearer token for service of type sdm: HTTP response from https://authentication.eu10.hana.ondemand.com/oauth/token was 401: {"error":"unauthorized","error_description":"Unable to map issuer: Origin claim is missing in the token.}"
in lib/sdm.js --> getDestination method.
Therefore, we changed the coding in method “getDestination”. If “origin” is not set in jwt, we use the technical client credential access (transformSDMServiceBindingToClientCredentialsDestination).
Type of change
Checklist before requesting a review
Upload Screenshots/lists of the scenarios tested