Skip to content

[CHORE] #20 - Update example-app to use Capacitor 8 compatible plugin version (v8.0.0)#24

Open
andreimuha-ionic wants to merge 1 commit into
masterfrom
chore/20-update-example-app-to-use-capacitor-8-compatible-plugin-version
Open

[CHORE] #20 - Update example-app to use Capacitor 8 compatible plugin version (v8.0.0)#24
andreimuha-ionic wants to merge 1 commit into
masterfrom
chore/20-update-example-app-to-use-capacitor-8-compatible-plugin-version

Conversation

@andreimuha-ionic

Copy link
Copy Markdown
Collaborator

No description provided.

@ryaa ryaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

I reviewed the PR and also validated the example app locally.

What looks good

  • The example app changes themselves look correct for the Capacitor 8 migration scope.
  • The example app dependencies were updated to Capacitor 8 / plugin v8.0.0.
  • iOS and Android native config changes appear aligned with the Capacitor 8 baseline.

Validation result

I initially hit a blocker when building the example app on Node 20, because the Capacitor CLI now requires Node >=22.

After switching via nvm to Node 22, I was able to build and run the example app successfully, so the upgrade itself appears to be working correctly.

Remaining blocker

At this point, the only remaining blocker seems to be the repo Node version baseline.

The repo still has .nvmrc pinned to 20.11.1, which leads contributors to use a Node version that breaks the example-app Capacitor 8 flow.

Requested change

Please update .nvmrc to a Node 22 version so that the repo setup matches the actual requirements of the upgraded example app.

It may also be worth updating any related CI/docs in a follow-up for consistency, but from my review the key required fix for this PR is the .nvmrc bump.

Review outcome

Request changes

Once .nvmrc is updated to Node 22, I believe this PR should be in good shape.

@andreimuha-ionic can you please take a look? thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] Update example-app to use Capacitor 8 compatible plugin version (v8.0.0)

2 participants