Return for failing range asserts to enforce the assumptions. #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
force-pushed
the
xtensa-asserts
branch
from
1b8a695 to
80895fa
Compare
wargio
approved these changes
Dec 17, 2025
Rot127
force-pushed
the
xtensa-asserts
branch
from
80895fa to
dac3b90
Compare
Rot127
force-pushed
the
xtensa-asserts
branch
from
dac3b90 to
38cf4f3
Compare
b1llow
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This might not be the best solution. It depends on the answer to #2828 (comment)
Test plan
All green
Closing issues
closes #2828
closes #2827
closes #2826