feat: fix nlohmann_json linkage from PRIVATE to PUBLIC #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Change target_link_libraries for nlohmann_json from PRIVATE to PUBLIC since nlohmann::json types are exposed in public headers (casbin_types.h, evaluator.h, and data_types.h). This ensures proper propagation of the dependency to downstream consumers and prevents ABI mismatches when multiple versions of nlohmann_json are present. Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix nlohmann_json linking for public headers
Fix nlohmann_json linkage from PRIVATE to PUBLIC
Feb 8, 2026
hsluoyz
changed the title
hsluoyz
added a commit
that referenced
this pull request
Feb 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #269