Extend nested module completion fixes to zsh, bash, fish, PowerShell, and Nushell#3112
Closed
kitsuyui wants to merge 5 commits intocasey:masterfrom
Closed
Extend nested module completion fixes to zsh, bash, fish, PowerShell, and Nushell#3112kitsuyui wants to merge 5 commits intocasey:masterfrom
kitsuyui wants to merge 5 commits intocasey:masterfrom
Conversation
Resolve the current module path during zsh completion so completion can continue inside nested modules instead of stopping after the first module segment. Add a zsh regression test covering nested module recipes.
Resolve the current module path during bash completion so nested module recipes can be completed level by level. Add regression fixtures and tests covering nested module names and recipes.
Complete module names and nested module recipes in fish based on the current module path, and add a regression test that exercises nested module completion with complete -C.
Resolve the current module path for PowerShell completion, guard optional justfile handling, and add a TabExpansion2 regression test for nested module completion.
Traverse nested modules from the current completion context in Nushell, and add a completion test that checks root, module, and nested recipe matches.
kitsuyui
force-pushed
the
inspect-other-shell-module-completion
branch
from
ef7580d to
2a6011a
Compare
Owner
|
I switched to using Clap's dynamic completion engine in #3167. The new completion engine calls into the I created #2406 to track improvements to the new completion engine in one place. The new completion engine partially fixes this by completing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the work in #3111 and further addresses #2912 for other shells.
The original zsh fix in #3111 resolved nested module completion by tracking the current module path and completing against the current module level instead of stopping after the first segment. This branch applies the same idea to additional shells that showed the same behavior.
Shells updated in this PR:
What changed:
Tests:
cargo test completions -- --nocaptureThis is intended as a follow-up to #3111, using the same approach for shells that still exhibited the module-completion problem described in #2912.