Refactor: remove detectioncontext instanceof#424
Open
Sanchay117 wants to merge 1 commit into
Open
Conversation
…ators Signed-off-by: sanchaysingh <sanchay072@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix : #165
Summary
Change all
translatefunction signatures across the translation layer to acceptDetectionContext(concrete abstract class) instead ofIDetectionContext(interface). This eliminates unnecessaryinstanceof DetectionContextruntime type checks.Changes
Core Interface & Abstract Class
IContextTranslation<T>: Changedtranslate()parameter fromIDetectionContext→DetectionContextITranslator<R,T,S,P>: Changed abstracttranslate()parameter andtranslateStore()local variable to useDetectionContext(with a cast at theDetectionStoreboundary)Engine Model Hierarchy
PRNGContext: Now extendsDetectionContextinstead of directly implementingIDetectionContextProtocolContext: Now extendsDetectionContextinstead of directly implementingIDetectionContextThis brings all context types into the
DetectionContexthierarchy, making the cast inITranslator.translateStore()safe.Language Translators (4 modules)
JavaTranslator,JavaAbstractLibraryTranslator,JavaCipherContextTranslator,JavaDigestContextTranslator,JavaSignatureContextTranslator,JavaKeyContextTranslator,JavaMacContextTranslator,JavaKeyAgreementContextTranslator,JavaAlgorithmParameterContextTranslator,JavaSecretKeyContextTranslator,JavaPRNGContextTranslator,JavaProtocolContextTranslatorPythonTranslator,PycaCipherContextTranslator,PycaDigestContextTranslator,PycaKeyAgreementContextTranslator,PycaKeyDerivationContextTranslator,PycaMacContextTranslator,PycaPrivateKeyContextTranslator,PycaPublicKeyContextTranslator,PycaSecretContextTranslator,PycaSecretKeyContextTranslator,PycaSignatureContextTranslatorGoTranslator,GoCipherContextTranslator,GoDigestContextTranslator,GoKeyContextTranslator,GoMacContextTranslator,GoPRNGContextTranslator,GoProtocolContextTranslator,GoSignatureContextTranslatorCSharpTranslator,CSharpCipherContextTranslator,CSharpDigestContextTranslator,CSharpKeyContextTranslator,CSharpMacContextTranslatorWhat was removed
All
instanceof DetectionContext contextchecks in translator methods, replaced with direct usage of thedetectionContextparameter. For example:Testing