Aggregate semantics in Policy Compiler - #1408
Open
TristonianJones wants to merge 3 commits into
Open
Conversation
TristonianJones
commented
Aug 15, 2026
| } | ||
| } | ||
|
|
||
| if output == nil { |
Collaborator
Author
There was a problem hiding this comment.
@l46kok - This is a bit different from cel-java because output isn't initialized to a base step in order to avoid superfluous + [] appearing in the output expression. I believe you handle this with the constant folding and CSE in Java, but constant-folding isn't turned on by default for policy composition in order to preserve the round-trip to source metadata for coverage purposes.
TristonianJones
force-pushed
the
aggregate-policy
branch
from
August 15, 2026 01:03
fcad62d to
4107c63
Compare
TristonianJones
force-pushed
the
aggregate-policy
branch
from
August 15, 2026 01:08
4107c63 to
1bfe113
Compare
TristonianJones
commented
Aug 15, 2026
| } | ||
| } | ||
|
|
||
| func TestRuleComposerError(t *testing.T) { |
Collaborator
Author
There was a problem hiding this comment.
These moved into composer_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
aggregatesemantics into Policy Compiler.The CEL policy compiler initially started as
first-matchpolicy compilation, ensuring atmost one result would be produced from a policy expression evaluation. With
aggregatesemantics, multiple outputs can be produced on a single pass. For those familiar with K8s
validating admission policies, the effect is similar.
Ported from cel-expr/cel-java/pull/1052
====
Aggregate walks through all matching rules (including nested ones) and appends them into a list:
Few noteworthy design decisions below. All examples assume all conditions matched:
optional.none()are pruned (except in cases where policy output explicitly emits anoptional.none()):Note: nesting
aggregateclauses is currently not allowed, and will result in a compilation error.