fix: support CeloDynamicFeeTxV2 (CIP-64) in span batches#430
Merged
palango merged 3 commits intocelo-rebase-16from Mar 25, 2026
Merged
fix: support CeloDynamicFeeTxV2 (CIP-64) in span batches#430palango merged 3 commits intocelo-rebase-16from
palango merged 3 commits intocelo-rebase-16from
Conversation
Span batch encoding/decoding failed on Celo CIP-64 transactions (type 0x7b) because the tx type switch statements only handled legacy, access list, dynamic fee, and set code types. Add spanBatchCeloDynamicFeeTxV2Data to carry the FeeCurrency field through the encode/decode round trip, and wire it into all 5 switch sites: newSpanBatchTx, decodeTyped, convertToFullTx, recoverV, and convertVToYParity.
karlb
approved these changes
Mar 25, 2026
karlb
left a comment
karlb
left a comment
There was a problem hiding this comment.
Too bad this isn't just adding a CeloDynamicFeeTxV2Type to a list. The diff isn't short, but at least it is quite simple.
Author
|
Tests only fail on RPC limits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Span batch encoding/decoding failed on Celo CIP-64 transactions (type 0x7b) because the tx type switch statements only handled legacy, access list, dynamic fee, and set code types.
Add spanBatchCeloDynamicFeeTxV2Data to carry the FeeCurrency field through the encode/decode round trip, and wire it into all 5 switch sites: newSpanBatchTx, decodeTyped, convertToFullTx, recoverV, and convertVToYParity.
Resolves https://github.com/celo-org/celo-blockchain-planning/issues/1360