Docker testing and validation#1450
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
While making changes to the documentation, I found having to install NodeJS to run the Next server and linting validation wasn't always desired. I've created a dockerfile and makefile to perform the same tasks. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: David Noyes <david.noyes@venafi.com>
5b500ea to
6958121
Compare
|
This does go against the conventions of the other repos, doing everything in docker by default. But it also would make development easier, probably need some further opinions. Other repos vendor all dependencies, though that could get heavy if we need to vendor nodejs itself |
|
I'd say that this change doesn't set a new default but just adds another option. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.