Skip to content

Add adcs-issuer (lcwsre) to external issuers list#2004

Open
lcwsre wants to merge 1 commit intocert-manager:masterfrom
lcwsre:add-lcwsre-adcs-issuer
Open

Add adcs-issuer (lcwsre) to external issuers list#2004
lcwsre wants to merge 1 commit intocert-manager:masterfrom
lcwsre:add-lcwsre-adcs-issuer

Conversation

@lcwsre
Copy link

@lcwsre lcwsre commented Mar 11, 2026

What

Add lcwsre/adcs-issuer to the external issuers list.

Why

lcwsre/adcs-issuer is an enhanced fork of the existing nokia/adcs-issuer with significant improvements for enterprise ADCS environments:

  • Custom Certificate Template Selection: Supports annotation-based ADCS template selection (cert-manager.io/cert-template) per Certificate/Ingress, allowing enterprises to use their own templates (WebServer, SubCA, custom server/client auth templates) instead of being hardcoded to BasicSSLWebServer.
  • Kerberos (SPNEGO) Authentication: Full Kerberos support via gokrb5/v8 for domain-integrated environments, in addition to HTTP Basic Auth.
  • Ingress Annotation Support: Resolves cert-manager.io/cert-template from Ingress annotations through the owner chain (Ingress → Certificate → CertificateRequest), so ingress-shim users don't need to create Certificate resources manually.
  • Both Issuer and ClusterIssuer: Supports namespace-scoped AdcsIssuer and cluster-scoped ClusterAdcsIssuer.
  • Helm Chart: Comprehensive Helm chart available at https://lcwsre.github.io/adcs-issuer/.
  • Actively maintained: Regular releases, Go 1.26+, BSD-3-Clause license.

The existing adcs-issuer entry (djkormo) is kept as-is since it's a separate project.

Tier

🥈 (Maintained) — Released within 12 months, open source (BSD-3-Clause).

Changes

  1. Added new table row for adcs-issuer (lcwsre) after the existing adcs-issuer entry
  2. Added [config:adcs-issuer-lcwsre] reference link
  3. Added [release:adcs-issuer-lcwsre] reference link

@cert-manager-prow cert-manager-prow bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Mar 11, 2026
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 11, 2026
@netlify
Copy link

netlify bot commented Mar 11, 2026

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 79e810c
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/69b14489f42639000841ae61
😎 Deploy Preview https://deploy-preview-2004--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: LC Waikiki SRE Team <lcwsre@lcwaikiki.com>
@lcwsre lcwsre force-pushed the add-lcwsre-adcs-issuer branch from f6286a2 to 79e810c Compare March 11, 2026 10:31
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 11, 2026
@lcwsre
Copy link
Author

lcwsre commented Mar 11, 2026

/test all

@cert-manager-prow
Copy link
Contributor

@lcwsre: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lcwsre
Copy link
Author

lcwsre commented Mar 13, 2026

Hi @inteon, friendly ping on this PR.

This adds lcwsre/adcs-issuer as a new external issuer entry an enhanced fork of the existing nokia/adcs-issuer with:

  • ADCS template selection via annotation
  • Kerberos (SPNEGO) + Basic auth
  • Ingress annotation propagation

The Netlify preview is ready and all automated checks pass. Would appreciate a review when you get a chance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant