Composition api by frankrousseau · Pull Request #1967 · cgwire/kitsu

frankrousseau · 2026-03-10T23:34:02Z

Problem

Kitsu needs to be migrated to the composition API
AI reviewing was required on libs.

Solution

First step of the migration: migrate widget components
Run the review and fixes

- errors.js: compare window.location.pathname instead of window.location object - models.js: check findIndex result against -1 instead of null - lang.js: fix zh_Hant_TW language code typo (zw -> zh) - query.js: encode URI components to prevent broken query strings Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- video.js: extract PRECISION_FACTOR constant and roundPrecision helper, replace deprecated substr with substring - render.js: batch all mention/department/taskType replacements into a single regex pass instead of O(n²) replaceAll loops - indexing.js: use substring prefix instead of character-by-character string concatenation - sorting.js: cache getTaskTypePriorityOfProd results before sorting to avoid redundant calls per comparison Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- csv.js: merge getStatReportsEntries and getRetakeStatReportsEntries into one function with options parameter (excludeStatuses, sortEntries) - time.js: extract shared adjustBusinessDays helper for addBusinessDays and removeBusinessDays - sorting.js: consolidate 5 sort*Result functions into a single sortEntityResult helper with per-entity config - indexing.js: extract createIndexPair factory to replace 8 duplicated Object.create(null) pairs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- query.js: rename 'couples' to 'pairs' for standard naming - models.js: simplify populateTask with array-based name building - stats.js: extract createStatusEntry factory for repeated init blocks - colors.js: simplify fromString with single conditional ColorHash instance Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- drafts.js: add try-catch for localStorage operations (quota/security) - preferences.js: add radix parameter to parseInt - videoCache.js: remove console.log left in production code - colors.js: extract DARK_STATUS_NAMES constant for validationTextColor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- video.js: extract DEFAULT_FPS constant (25) - stats.js: extract RETAKE_CHART_COLORS and DEFAULT_STATUS_COLOR constants - time.js: extract SUNDAY/SATURDAY as module-level constants, use isoWeeksInYear() instead of hardcoded 52 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- func.js: use Date.now() instead of new Date().getTime() - descriptors.js: add guard for missing descriptor.choices - crisp.js: add onerror handler for script load failure, remove unnecessary IIFE Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add 4 new test files (clipboard, drafts, productions, errors) and expand 7 existing test files with additional edge case coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove unused variables and parameters, convert promise callbacks to async/await, fix useless escapes, and add eslint-disable comments for browser globals in test environment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Extract duplicated task status color logic from ComboboxStatus and ValidationTag into a shared useTaskStatusStyle composable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Extract duplicated @-mention member list logic (reactive state, filter function, team/taskTypes watchers) from AddComment and Comment into a shared useAtMentionsMembers composable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Extract the common toggle/select/showList pattern from ComboboxStatus, ComboboxStatusAutomation, ComboboxStudio, and ComboboxProduction into a shared useCombobox composable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Convert all function declarations in widget components to arrow functions for consistency with the composables and modern style. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add 128 tests covering Combobox family (Combobox, ComboboxSimple, ComboboxStyled, ComboboxBoolean, ComboboxNumber, ComboboxStatus, ComboboxTag), SearchField, Checklist, and AddComment widgets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

NicoPennec

LGTM, just 2 minor changes

NicoPennec · 2026-03-11T08:52:00Z

src/lib/preferences.js

  getIntPreference(key, defaultValue = 0) {
    const item = this.getPreference(key)
-    const value = parseInt(item)
+    const value = parseInt(item, 10)


Radix is useless in modern browsers

NicoPennec · 2026-03-11T09:07:26Z

src/lib/lang.js

 const LOCALE_MAP = {
  zh_Hans_CN: { language: 'zh', localeCode: 'zh-cn' },
-  zh_Hant_TW: { language: 'zw', localeCode: 'zh-tw' }
+  zh_Hant_TW: { language: 'zh', localeCode: 'zh-tw' }


It's not a typo, 'zw' is the right value

frankrousseau and others added 30 commits March 5, 2026 02:47

[tests] improve lib test coverage with new and expanded tests

e368885

Add 4 new test files (clipboard, drafts, productions, errors) and expand 7 existing test files with additional edge case coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[qa] run linter

b86e825

[qa] Remove e2e tests not used

396fce0

[tests] fix ESLint errors across test files

2002c61

Remove unused variables and parameters, convert promise callbacks to async/await, fix useless escapes, and add eslint-disable comments for browser globals in test environment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[qa] Add tests linting commands

a59b65e

[widgets] convert AddComment to composition API

dbb2172

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert AssignationItem to composition API

77cf1b5

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert BooleanField to composition API

26a8246

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert BooleanRep to composition API

59efb1d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ButtonHrefLink to composition API

273b70c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ButtonLink to composition API

91a58b1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ButtonSimple to composition API

2065a03

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert Checkbox to composition API

885d9f9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert Checklist to composition API

7f8939b

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ColorField to composition API

7d6bfe5

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ColorPicker to composition API

f1bc6f6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ComboboxBoolean to composition API

b38adbb

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ComboboxDepartment to composition API

8938826

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ComboboxMask to composition API

ffb81c8

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ComboboxModel to composition API

a6dc4ec

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ComboboxNumber to composition API

3d15255

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ComboboxProduction to composition API

8a71881

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ComboboxSimple to composition API

0cbab73

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

frankrousseau and others added 28 commits March 5, 2026 11:10

[widgets] convert Schedule to composition API

a24abe0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert SearchField to composition API

955327e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert SearchQueryList to composition API

65dab20

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert SettingImporter to composition API

c0e74ab

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ShowInfosButton to composition API

bdf210c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert SortingInfo to composition API

7865233

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert Spinner to composition API

0820754

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert StatusAutomationItem to composition API

17e0d98

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert StatusStats to composition API

265ef4a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert SubscribeButton to composition API

0d11b5d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert TableHeaderMenu to composition API

e779970

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert TableInfo to composition API

cb07287

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert TableMetadataHeaderMenu to composition API

6bdf17c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert TableMetadataSelectorMenu to composition API

8f4637e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert TaskListNumbers to composition API

2c1283b

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert TaskTypeName to composition API

cff86fc

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert TextareaField to composition API

4e2cc3b

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert TextField to composition API

5ff647d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert TwoFactorAuthentication to composition API

a6ff92f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert UserCalendar to composition API

5bde259

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] convert ValidationTag to composition API

eec7f8a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[composables] Extract useTaskStatusStyle composable

5a15733

Extract duplicated task status color logic from ComboboxStatus and ValidationTag into a shared useTaskStatusStyle composable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[composables] Extract useCombobox composable

15ec013

Extract the common toggle/select/showList pattern from ComboboxStatus, ComboboxStatusAutomation, ComboboxStudio, and ComboboxProduction into a shared useCombobox composable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[composables] Use arrow functions instead of classic functions

11b26d0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] Use arrow functions instead of classic functions

2dcaf4b

Convert all function declarations in widget components to arrow functions for consistency with the composables and modern style. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

[widgets] Apply linter formatting to arrow functions

4604e1d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mergify bot assigned frankrousseau Mar 10, 2026

NicoPennec requested changes Mar 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Composition api#1967

Composition api#1967
frankrousseau wants to merge 92 commits intocgwire:mainfrom
frankrousseau:composition-api

frankrousseau commented Mar 10, 2026 •

edited

Loading

Uh oh!

NicoPennec left a comment

Uh oh!

NicoPennec Mar 11, 2026

Uh oh!

NicoPennec Mar 11, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

frankrousseau commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NicoPennec left a comment

Choose a reason for hiding this comment

Uh oh!

NicoPennec Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

NicoPennec Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

frankrousseau commented Mar 10, 2026 •

edited

Loading

NicoPennec Mar 11, 2026 •

edited

Loading