fix(build): restore static native RE2 for full artifacts - #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chainreactors/go-re2replacement to the revision with static native RE2 supportaiscan-fullrelease target and GoReleaser artifact withre2_cgo re2_static.exesuffix and verify both Windows outputs existWhy
Full release artifacts should use the native RE2 backend without requiring a shared RE2 library at runtime. The CI checks keep the release tags aligned with the tested Windows build and make Windows artifact names deterministic.
Verification
go mod tidy -diffgo test -count=1 ./core/resourcesgo test -count=1 ./cmd/aiscanCGO_ENABLED=1 go test -count=1 -tags "re2_cgo re2_static" ./agent/... ./pkg/runner/... ./pkg/web/...CGO_ENABLED=1 go test -count=1 -tags "forceposix emptytemplates noembed osusergo netgo full sqlite re2_cgo re2_static" ./cmd/aiscan