Bump onig/onig_sys versions to fix GCC 15 build errors#161
Open
eitamal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply bumps the versions of the
onigandonig_syspackages (dependents ofsyntect), similar to rust-lang/rust#141684, to fix the errors and warnings that happen when runningcargo buildunder a system with GCC 15.As an example, this is what I was getting:
Note: Technically, you can get around this issue by installing the oniguruma library (e.g.
sudo apt install libonig-dev) and tellingonig_systo use that instead (which should speed up the build, too), for example:RUSTONIG_SYSTEM_LIBONIG=1 cargo build. But, I thought the version bump was more practical.