fix(vcard): Improve property value escaping#7931
Merged
Conversation
j-g00da
force-pushed
the
j-g00da/vcard-newlines-escape
branch
from
4b98c03 to
8d29b2d
Compare
Contributor
Author
|
I decided to implement whole rfc6350 escaping, so we don't run into the same issues with backslashes or semicolons. I don't think this needs a separate test, as this is tested by round trip ( |
j-g00da
force-pushed
the
j-g00da/vcard-newlines-escape
branch
from
8d29b2d to
ef2d072
Compare
link2xt
reviewed
Mar 2, 2026
j-g00da
force-pushed
the
j-g00da/vcard-newlines-escape
branch
from
ef2d072 to
252ea11
Compare
Implements property value escaping according to RFC6350 section 3.4. <https://www.rfc-editor.org/rfc/rfc6350.html#section-3.4> Fixes: #7893
j-g00da
force-pushed
the
j-g00da/vcard-newlines-escape
branch
from
252ea11 to
0cc908f
Compare
Collaborator
|
@j-g00da in core, usually, the person who opened the PR merges it as soon as he/she thinks that it got enough scrutiny now. This ensures that the PR is merged in the way the author intended (squash/merge commit/rebase). So, that's on you now (I assume you have sufficient permissions for this?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements property value escaping according to RFC6350 section 3.4. https://www.rfc-editor.org/rfc/rfc6350.html#section-3.4
Fixes: #7893