Conversation
Don't request Chat-Version header during prefetch, and don't depend on it for the question whether we download a message. We will still need to prefetch the Chat-Version header so that move works; this will be fixed with https://github.com/chatmail/core/pull/7780/changes
Hocuri
force-pushed
the
hoc/remove-chat-version-from-prefetch
branch
from
68b1124 to
01d775f
Compare
Hocuri
changed the title
Hocuri
changed the title
Hocuri
changed the title
iequidoo
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't depend on these 3 cleartext headers for the question whether we download a message.
This PR will waste a bit of bandwidth for people who use the legacy show_emails option; otherwise, there is no user-visible change yet. It's a preparation for being able to remove these headers, in order to further reduce unencrypted metadata.
Removing In-Reply-To and References will be easy; removing Chat-Version must happen at least one release after the PR here is released, so that people don't miss messages. Also, maybe some nerds depend on the Chat-Version header for server-side filtering of messages, but we shall have this discussion at some other time.
For the question whether a message should be moved, we do still depend on them; this will be fixed with #7780.
When both this PR and #7780 are merged, we can stop requesting Chat-Version header during prefetch.