fix: Use the correct chat description stock string again#7939
Merged
Conversation
Apparently I was inattentive when reviewing #7870; there even was a test that tested that the incorrect description is used XD
Hocuri
force-pushed
the
hoc/fix-chat-description-changed-msg
branch
from
97a731b to
31896a2
Compare
iequidoo
approved these changes
Mar 3, 2026
| } | ||
|
|
||
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] | ||
| async fn test_chat_description_unpromoted_description() { |
Collaborator
There was a problem hiding this comment.
Maybe merge this into the previous test, at least to not duplicate the comment?
Collaborator
Author
There was a problem hiding this comment.
Right now, everything is very systematic; there are 4 tests for the 4 combinations of the first 2 arguments. There are two places where readers might wonder why it's not tested for broadcast channels, therefore the duplicate comment
Contributor
|
thanks for fixing, @Hocuri! |
r10s
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7933
Apparently I was inattentive when reviewing
#7870; there even was a test that tested that the incorrect description is used XD
Thanks for noticing @r10s!