fix(cmdeploy): make tests work with --ssh-host localhost#856
Conversation
|
Hm, |
The journald of chatmaild-metadata claims: running it later suddenly succeeds. It should be run after the tests which create addresses. |
In https://github.com/chatmail/relay/actions/runs/22133199294/job/63978158827?pr=852 it failed again - the logs say, that the chatmail-metadata.service simply wasn't running at the time: So it's a question of service startup time. We should throw in a |
|
Hm, seems like directly after activating dovecot, /home/vmail/mail still doesn't exist, chatmail-metadata failed again. |
dae8baf to
1b6401d
Compare
I simply lowered RestartSec for chatmail-metadata - 10 was still a close call until the tests ran, 5 should be a bit safer. So this should be fixed now, ready for review :) |
1b6401d to
c410f7a
Compare
* tests: fix test_remote[imap] * cmdeploy: call LocalExec directly, not .logged() * tests: fix TestSSHExecutor.test_logged * tests: fix test_status_cmd with --ssh-host @Local * tests: fix test_logged with --ssh-host localhost * tests: fix TestSSHExecutor::test_exception with --ssh-host localhost * ci: deploy with --ssh-host localhost on staging-ipv4 * metadata: lower RestartSec
fix a flaky test: #856 (comment) since #856 chatmail-metadata is restarted every 5 second, if it didn't come up after that, the failure likely sits deeper.
fix a flaky test: #856 (comment) since #856 chatmail-metadata is restarted every 5 second, if it didn't come up after that, the failure likely sits deeper.
Taken out of #852, in any case also useful for docker, and anyone who uses
ssh-host localhosttoday.(let's squash them on merging)