Draft
Conversation
j-g00da
temporarily deployed
to
staging2.testrun.org
GitHub Actions
Inactive
j-g00da
temporarily deployed
to
staging-ipv4.testrun.org
GitHub Actions
Inactive
missytake
reviewed
Feb 26, 2026
Contributor
missytake
left a comment
missytake
left a comment
There was a problem hiding this comment.
I don't think this approach would work, see my comment. In any case, this PR needs a test.
|
|
||
| # We want to filter bounce messages, so that they are DKIM signed. | ||
| # filtermail MUST NOT reject any outgoing bounce messages. | ||
| internal_mail_filter_classes = bounce |
Contributor
There was a problem hiding this comment.
According to man 5 postconf, this option defines What categories of Postfix-generated mail are subject to before-queue content inspection by non_smtpd_milters, header_checks and body_checks.
opendkim is running as an smtpd_milter, filtermail as an smtpd_proxy - so this would not be enough to pass the mail to them.
Collaborator
Author
There was a problem hiding this comment.
yup, I forgot to mark this as a draft! I only started to dig into that :)
j-g00da
force-pushed
the
j-g00da/sign-bounce
branch
from
2e2e6cd to
0bfc671
Compare
j-g00da
force-pushed
the
j-g00da/sign-bounce
branch
from
0bfc671 to
ada0060
Compare
j-g00da
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Failure
j-g00da
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Failure
j-g00da
force-pushed
the
j-g00da/sign-bounce
branch
from
ada0060 to
9dac959
Compare
j-g00da
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Failure
j-g00da
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Failure
j-g00da
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Failure
j-g00da
force-pushed
the
j-g00da/sign-bounce
branch
from
9dac959 to
43590d3
Compare
j-g00da
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Failure
j-g00da
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Failure
j-g00da
force-pushed
the
j-g00da/sign-bounce
branch
from
43590d3 to
b197edf
Compare
j-g00da
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Failure
j-g00da
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Failure
j-g00da
force-pushed
the
j-g00da/sign-bounce
branch
from
b197edf to
726837f
Compare
j-g00da
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Failure
j-g00da
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Failure
j-g00da
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Error
j-g00da
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Error
j-g00da
force-pushed
the
j-g00da/sign-bounce
branch
from
ae0ef53 to
40ee20f
Compare
j-g00da
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Failure
j-g00da
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Failure
Closes #873 Signed-off-by: Jagoda Ślązak <jslazak@jslazak.com>
j-g00da
force-pushed
the
j-g00da/sign-bounce
branch
from
40ee20f to
d0d5635
Compare
j-g00da
requested a deployment
to
staging-ipv4.testrun.org
GitHub Actions
In progress
j-g00da
requested a deployment
to
staging2.testrun.org
GitHub Actions
In progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #873