You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add support for propagating Session arguments to the chdb connection. This is essential when TLS configuration is required (for example when using the remoteSecure table function).
Clean up code in SessionBuilder::build, Connection::open, remove unmaintainted dev dependency tempdir (replaced with tempfile) and add more tests.
Reverted the tempdir removal. It looks like tempfile is causing SIGSEGV when loading libchdb.so in integration tests on Linux. Doesn't happen on Mac OS. I am not entirely sure why.
Also, note that the same thing happens on the current main branch too, if we try to use tempfile instead of tempdir. So it has nothing to do with any changes on this branch. In fact, the SIGSEGV happens before any Rust code is executed at all.
Connection::open prepends CHDB_PROGRAM_NAME ("clickhouse") itself so any existing caller doing the previously-documented Connection::open(&["clickhouse", "--path=/tmp/db"]) will now produce argv ["clickhouse", "clickhouse", "--path=/tmp/db"].
This will either be handled by the clickhouse client or not, but worth noting
Connection::open prepends CHDB_PROGRAM_NAME ("clickhouse") itself so any existing caller doing the previously-documented Connection::open(&["clickhouse", "--path=/tmp/db"]) will now produce argv ["clickhouse", "clickhouse", "--path=/tmp/db"].
This will either be handled by the clickhouse client or not, but worth noting
Thanks for pointing this out. This works with the current chDB C API: the second "clickhouse" is effectively ignored and "--path=/tmp/db" is still parsed correctly. But I agree it is redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for propagating
Sessionarguments to thechdbconnection. This is essential when TLS configuration is required (for example when using theremoteSecuretable function).Clean up code in
SessionBuilder::build,Connection::open, remove unmaintainted dev dependencytempdir(replaced withtempfile) and add more tests.