feat: add static linking support and improve download reliability#28
Merged
Conversation
- Introduce 'static' feature flag to Cargo.toml - Update build.rs to fetch and link static libchdb archives - Increase download timeout to 600s and stream to disk to prevent OOM - Link stdc++ when static feature is enabled
|
|
Contributor
Author
|
The project should feel free to use the code provided in this PR if desired even though I will not be signing the current CLA. Really appreciate this library! |
Contributor
|
Hi @ION28, CLA has been updated, feel free to check it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #27 - Closes #27
Proposed benefit: Static linking significantly increases the final binary size but removes all runtime shared library requirements for chDB to support more portable applications.
Change summary:
I have tested this successfully bundling into my application without supplying the features as well as supplying --features = static and confirmed the resulting ldd output shows the binary appearing (dynamic resolve) vs not appearing (statically linked).
How to test:
Dynamic (Default/current behavior):
cargo build ldd target/debug/libyour_project.so # Should show dependency on libchdb.soStatic:
cargo build --features static ldd target/debug/libyour_project.so # Should NOT show libchdb.so as a dependency