Skip to content
This repository was archived by the owner on Feb 23, 2022. It is now read-only.

roger - no ticket - create statusWrapper component#449

Open
roggc wants to merge 1 commit into
masterfrom
terminal-inventory
Open

roger - no ticket - create statusWrapper component#449
roggc wants to merge 1 commit into
masterfrom
terminal-inventory

Conversation

@roggc

@roggc roggc commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

img1

@ralph-dev ralph-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roggc Doesn't this component already exist?

@roggc

roggc commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

@roggc Doesn't this component already exist?

yes. the thing is I add a property named 'separation' to add space (margin) between the status dot and the text. the second is also the color of the text to be different than the color of the dot.

@ralph-dev

Copy link
Copy Markdown
Member

@roggc Doesn't this component already exist?

yes. the thing is I add a property named 'separation' to add space (margin) between the status dot and the text. the second is also the color of the text to be different than the color of the dot.

Ok I feel like you could have just extended properties on the existing component though. Also use the CE Repo not this Repo anymore

@roggc

roggc commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

@roggc Doesn't this component already exist?

yes. the thing is I add a property named 'separation' to add space (margin) between the status dot and the text. the second is also the color of the text to be different than the color of the dot.

Ok I feel like you could have just extended properties on the existing component though. Also use the CE Repo not this Repo anymore

sorry, which is the CE Repo?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants