Clarify binary response handling for API checks - #452
Merged
thebiglabasky merged 1 commit intoJul 27, 2026
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
thebiglabasky
marked this pull request as ready for review
July 27, 2026 14:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application/octet-stream, but does not decode genuinely binary formatsWhy
ENG-154 reports that customers cannot assert on health responses served as
application/octet-stream. The runner behavior shipped incheckly/monorepo#2883already preserves the response body when a Text body assertion is configured, so this updates the API Check documentation to match the shipped behavior and its limits.Validation
go test ./check/api -run 'Test(DecideBinaryBodyScrub|ExecuteApiCheckBinaryScrubOptOut|MaxResponseBodySize)$' -count=1python3 .github/scripts/check_redirect_destinations.pypython3 .github/scripts/check_frontmatter.pynpx mint broken-linksgit diff --check