Issue #18435: Fix xdocs Examples AST Consistency Test - indentation#19950
Merged
Conversation
Contributor
Author
Contributor
Author
|
Github, generate site |
stoyanK7
approved these changes
May 26, 2026
Collaborator
stoyanK7
left a comment
stoyanK7
left a comment
There was a problem hiding this comment.
@smita1078 Please resolve conflicts.
Looks clean to me, though
romani
requested changes
May 26, 2026
| }; | ||
|
|
||
| void method2() | ||
| throws Exception { // ok, throwsIndent = 4 |
Member
There was a problem hiding this comment.
please make this line to be indented as 4, to let it violation when we do name="throwsIndent" value="8". It will be logical.
wihtout such update, it looks almost always as no violation.
smita1078
force-pushed
the
AST6_GSOC
branch
2 times, most recently
from
3a86a31 to
3166efd
Compare
Member
|
GitHub, generate website |
Member
|
Sorry , I actually meant Throws is +4 from method indentation |
Contributor
Author
Oh Okay, let me change it! |
Contributor
Author
|
GitHub, generate website |
Member
|
GitHub, generate website |
romani
approved these changes
May 27, 2026
Member
romani
left a comment
romani
left a comment
There was a problem hiding this comment.
hard work is done that I hope users will appreciate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18435
checks/indentation/indentation :
Example 1-9 - show different properties excluding example4
use case example:
example4
Properties each example demonstrates:
Example1 — default config
Example2 — caseIndent=0
Example3 — forceStrictCondition=true
Example4 — default config (same as Example1!) but showing violations
Example5 — basicOffset=2
Example6 — lineWrappingIndentation=8
Example7 — throwsIndent=8 (complex use case)
Example8 — arrayInitIndent=2
Example9 — braceAdjustment=2