Conversation
chizberg
commented
Apr 13, 2026
chizberg
commented
- issue Paintings support #115: paintings support
- Potential fix for pull request finding
- paintings strings update
- onboardings update
- version bump
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates app copy and onboarding UI to reflect new “paintings” support, along with localized Info.plist strings and a version bump.
Changes:
- Update public-facing documentation/privacy copy from “images” to “photos and paintings”.
- Rework onboarding screens to use scrollable layouts with over-scroll gradients and updated feature/annotation messaging.
- Update Info.plist usage strings (including localization catalog) and bump build/marketing versions.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| privacy.md | Updates privacy-policy wording to include paintings in location/PastVu descriptions. |
| README.md | Updates product/feature copy to mention photos and paintings. |
| Rewind/View/Onboarding/WelcomeScreen.swift | Converts onboarding welcome to a ScrollView layout with top/bottom gradient overlays. |
| Rewind/View/Onboarding/AnnotationsScreen.swift | Converts annotations onboarding to a ScrollView layout and updates header copy. |
| Rewind/InfoPlist.xcstrings | Updates localized Info.plist usage strings (notably location usage description). |
| Rewind/Info.plist | Updates the location usage description string value. |
| Rewind.xcodeproj/project.pbxproj | Bumps build number and marketing version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.md
Outdated
| - **Vintage images near you:** the app uses PastVu API to fetch images and their metadata and shows them on an Apple MapKit map | ||
| - **Favorites:** save images you like to view them later | ||
| - **Vintage photos and paintings near you:** the app uses PastVu API to fetch photos, paintings, and their metadata and shows them on an Apple MapKit map | ||
| - **Favorites:** save what you like to view it later |
There was a problem hiding this comment.
The updated Favorites feature description is grammatically incorrect: “save what you like to view it later”. Consider rephrasing to “save what you like to view later” or “save items you like to view them later”.
| - **Favorites:** save what you like to view it later | |
| - **Favorites:** save what you like to view later |
| .multilineTextAlignment(.leading) | ||
| .font(.largeTitle.bold()) | ||
|
|
||
| Text("How do images look?") |
There was a problem hiding this comment.
The new subtitle text “How do images look?” reads awkwardly in English. Consider using “What do the images look like?” (or similar) to keep the onboarding copy natural.
| Text("How do images look?") | |
| Text("What do the images look like?") |
| .overlay(alignment: .top) { | ||
| overscrollGradient.rotationEffect(.degrees(180)) | ||
| .frame(height: 80) | ||
| .ignoresSafeArea() |
There was a problem hiding this comment.
The top overlay adds a LinearGradient view over the scroll view without disabling hit testing. This overlay can intercept taps/scroll gestures in the top area (especially when starting a scroll near the top). Consider adding .allowsHitTesting(false) to this decorative gradient (and similarly for the bottom gradient if it’s ever moved out of .background).
| .ignoresSafeArea() | |
| .ignoresSafeArea() | |
| .allowsHitTesting(false) |
| } | ||
| }, | ||
| "NSLocationWhenInUseUsageDescription": { | ||
| "comment": "Privacy - Location When In Use Usage Description", |
There was a problem hiding this comment.
NSLocationWhenInUseUsageDescription is missing an extractionState field while the other Info.plist keys in this catalog include one. This inconsistency can confuse Xcode’s string-catalog tooling/merge behavior. Add the appropriate extractionState (likely extracted_with_value) to match the rest of the file.
| "comment": "Privacy - Location When In Use Usage Description", | |
| "comment": "Privacy - Location When In Use Usage Description", | |
| "extractionState": "extracted_with_value", |
