Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was pointed out to me that IS# results are way off. Indeed, +90% coins at level 4 seemed excessive.

After investigating, I noticed that these results happen because of the way you compare a mastery to the baseline. You normalize results of a wave X against the wave that happened at the same time in the baseline run, which means you compare IS#4 wave 4000 against baseline wave 3100-ish, and use that as the basis for your calculations.
I didn't want to get too deep into modifying your code since it's quite entangled and the potential to mess things up is there, so I created a flag that automatically extends runs to the same length based on their average rewards. This way the legend displays correct values for both relative increase and ROI per stone (I didn't come up with a simple and non-intrusive fix to the second one).
