FIX: relax mp requires-python to allow Python 3.12-3.14#804
FIX: relax mp requires-python to allow Python 3.12-3.14#804salvatoreasammito wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Python version compatibility constraints for the Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Python version requirement in pyproject.toml. The reviewer noted that the expanded version range violates the repository style guide, which mandates ">=3.11,<3.12". Additionally, the uv.lock file was not updated to reflect these changes, requiring a synchronization step.
| { name = "Eran Chriqui", email = "eranc@google.com" }, | ||
| ] | ||
| requires-python = ">=3.11,<3.12" | ||
| requires-python = ">=3.11,<3.15" |
There was a problem hiding this comment.
The requires-python constraint is being changed to >=3.11,<3.15, which violates the repository style guide requirement to use >=3.11,<3.12. While the motivation to support newer Python versions is noted, the style guide explicitly mandates the narrower range for consistency across the repository. If this package requires a broader range, the style guide should be updated accordingly.
| requires-python = ">=3.11,<3.15" | |
| requires-python = ">=3.11,<3.12" |
References
- The repository style guide specifies that requires-python should be set to >=3.11,<3.12. (link)
| { name = "Eran Chriqui", email = "eranc@google.com" }, | ||
| ] | ||
| requires-python = ">=3.11,<3.12" | ||
| requires-python = ">=3.11,<3.15" |
Summary
Relax
requires-pythoninpackages/mp/pyproject.tomlfrom>=3.11,<3.12to>=3.11,<3.15, allowingmpto be installed and used on Python 3.12, 3.13 and 3.14.Motivation
The current constraint locks
mpto Python 3.11.x only. This contradicts:The classifiers in the same
pyproject.toml, which already declare support for Python 3.12 and 3.13:"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
The installation guide at
packages/mp/docs/installation.md, which states "Python 3.11 or later (Python 3.11.0+ is officially supported)".Validation
Tested locally on Windows 11:
uv sync --python 3.14resolves all dependencies cleanly, no conflicts.mp --versionandmp --helpwork as expected.mp validate playbook <name>runs end-to-end and reportsAll Validations Passed.Python versions covered by the new constraint: 3.11, 3.12, 3.13, 3.14 (matches the upper-bound style used by many libraries — leaves 3.15 to be re-tested when released).
Notes
PYTHONUTF8=1is needed for emoji output in the console, but this is unrelated tompand applies to any Python 3.x app printing Unicode oncp1252consoles.