Skip to content

FIX: relax mp requires-python to allow Python 3.12-3.14#804

Open
salvatoreasammito wants to merge 1 commit into
chronicle:mainfrom
salvatoreasammito:fix/relax-mp-python-version
Open

FIX: relax mp requires-python to allow Python 3.12-3.14#804
salvatoreasammito wants to merge 1 commit into
chronicle:mainfrom
salvatoreasammito:fix/relax-mp-python-version

Conversation

@salvatoreasammito
Copy link
Copy Markdown
Contributor

Summary

Relax requires-python in packages/mp/pyproject.toml from >=3.11,<3.12 to >=3.11,<3.15, allowing mp to be installed and used on Python 3.12, 3.13 and 3.14.

Motivation

The current constraint locks mp to Python 3.11.x only. This contradicts:

  • The classifiers in the same pyproject.toml, which already declare support for Python 3.12 and 3.13:
    "Programming Language :: Python :: 3.12",
    "Programming Language :: Python :: 3.13",

  • The installation guide at packages/mp/docs/installation.md, which states "Python 3.11 or later (Python 3.11.0+ is officially supported)".

Validation

Tested locally on Windows 11:

  • uv sync --python 3.14 resolves all dependencies cleanly, no conflicts.
  • mp --version and mp --help work as expected.
  • mp validate playbook <name> runs end-to-end and reports All Validations Passed.

Python versions covered by the new constraint: 3.11, 3.12, 3.13, 3.14 (matches the upper-bound style used by many libraries — leaves 3.15 to be re-tested when released).

Notes

  • No code changes, only the version constraint.
  • On Windows, PYTHONUTF8=1 is needed for emoji output in the console, but this is unrelated to mp and applies to any Python 3.x app printing Unicode on cp1252 consoles.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Python version compatibility constraints for the mp package. By relaxing the upper bound of the requires-python field, the package now officially supports newer Python versions up to 3.14, resolving a discrepancy between the metadata and the project's stated support policy.

Highlights

  • Dependency Constraint Update: Updated the requires-python constraint in packages/mp/pyproject.toml from >=3.11,<3.12 to >=3.11,<3.15.
  • Compatibility Expansion: Enabled support for Python 3.12, 3.13, and 3.14 to align with existing project documentation and classifiers.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Python version requirement in pyproject.toml. The reviewer noted that the expanded version range violates the repository style guide, which mandates ">=3.11,<3.12". Additionally, the uv.lock file was not updated to reflect these changes, requiring a synchronization step.

{ name = "Eran Chriqui", email = "eranc@google.com" },
]
requires-python = ">=3.11,<3.12"
requires-python = ">=3.11,<3.15"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The requires-python constraint is being changed to >=3.11,<3.15, which violates the repository style guide requirement to use >=3.11,<3.12. While the motivation to support newer Python versions is noted, the style guide explicitly mandates the narrower range for consistency across the repository. If this package requires a broader range, the style guide should be updated accordingly.

Suggested change
requires-python = ">=3.11,<3.15"
requires-python = ">=3.11,<3.12"
References
  1. The repository style guide specifies that requires-python should be set to >=3.11,<3.12. (link)

{ name = "Eran Chriqui", email = "eranc@google.com" },
]
requires-python = ">=3.11,<3.12"
requires-python = ">=3.11,<3.15"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The requires-python constraint was updated but uv.lock was not updated. Run uv lock to sync and include the updated lockfile in the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant