[b/517348034] Migrating 5 new log_types from piper workspace to GitHub#877
[b/517348034] Migrating 5 new log_types from piper workspace to GitHub#877sontih-debug wants to merge 5 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the repository's log parsing capabilities by introducing support for several third-party security and database products. Each new parser includes the necessary configuration, metadata, and test datasets to ensure accurate data normalization and integration. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces Logstash/CBN configurations, metadata, and test data for several new log sources, including SOPHOS_DHCP, SYMANTEC_SA, TERADATA_DB, THREATLOCKER, and TRENDMICRO_VISION_ONE_CONTAINER_VULNERABILITIES. The reviewer identified several critical syntax and logical issues across these configurations that must be addressed before merging. Specifically, the use of unsupported native for loops in the SOPHOS_DHCP parser and the invalid on_error option inside mutate blocks in the SYMANTEC_SA and TERADATA_DB parsers will cause compilation errors. Additionally, initializing map fields to empty strings in the SYMANTEC_SA and TRENDMICRO parsers breaks nested UDM path assignments, while the THREATLOCKER parser contains an incorrect string-to-array comparison and an existence check on a boolean field that should be updated to an explicit equality check.
Description
The purpose of this migration is to establish a community Git repository that enables customer-driven parser updates. Customers will be able to pull the codebase, make modifications, and submit their changes for review and approval by the CBN team.
Log_types:
1.TRENDMICRO_VISION_ONE_CONTAINER_VULNERABILITIES
2.THREATLOCKER
3.TERADATA_DB
4.SOPHOS_DHCP
5.SYMANTEC_SA
Checklist:
Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only:
Screenshots (If Applicable)
If your changes involve UI or visual elements, please include screenshots or GIFs here.
Ensure any sensitive data is redacted or generalized.
Further Comments / Questions
Any additional comments, questions, or areas where you'd like specific feedback.
TAG SKIP_GOOGLE_PARSER_CHECK="Not Applicable for now"