feat: support topology-aware Service controls [sc-18128]#295
Merged
Conversation
paulohpigatto
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds chart interfaces for topology-aware Kubernetes Service controls:
trafficDistributionsupport.loadBalancerClass,externalTrafficPolicy, andtrafficDistribution.loadBalancerClass,externalTrafficPolicy, andtrafficDistribution.metricsServiceso metrics can stay on ClusterIP while public LoadBalancer Services expose only libp2p.This PR is the chart dependency for the app-of-apps rollout PR. Deployment rationale and operational baselines live in internal tracking.
Verification
helm lint charts/erpchelm lint charts/spirehelm lint charts/validatorhelm template erpc-test charts/erpc --set service.trafficDistribution=PreferSameZonehelm template spire-test charts/spire --set service.type=LoadBalancer --set service.loadBalancerClass=service.k8s.aws/nlb --set service.externalTrafficPolicy=Local --set service.trafficDistribution=PreferSameZone --set metricsService.enabled=true --set serviceMonitor.enabled=truehelm template validator-test charts/validator --set ghost.service.loadBalancerClass=service.k8s.aws/nlb --set ghost.service.externalTrafficPolicy=Local --set ghost.service.trafficDistribution=PreferSameZone --set vao.service.loadBalancerClass=service.k8s.aws/nlb --set vao.service.externalTrafficPolicy=Local --set vao.service.trafficDistribution=PreferSameZonect lint --config ct.yaml