Fix for Reddit and add features for Meta#143
Open
gnadgnaoh wants to merge 4 commits intochsbuffer:mainfrom
Open
Fix for Reddit and add features for Meta#143gnadgnaoh wants to merge 4 commits intochsbuffer:mainfrom
gnadgnaoh wants to merge 4 commits intochsbuffer:mainfrom
Conversation
chsbuffer
requested changes
Mar 9, 2026
Owner
chsbuffer
left a comment
chsbuffer
left a comment
There was a problem hiding this comment.
This pull request does not meet the consensus requirement of consistency with existing code style. Furthermore, this project primarily ports patches from ReVanced patches; for external contributors, I would appreciate it if you could clarify whether your code is updated upstream code, or original content.
Comment on lines
+14
to
+16
| methodMatcher { | ||
| usingStrings(listOf("blank_ad_container")) | ||
| } |
| Logger.printDebug { "Hide Comment" } | ||
| it.result = it.args[0] | ||
| Logger.printDebug { "Hide Comment Ad - invokeSuspend skipped" } | ||
| it.result = kotlin.Unit |
| } | ||
| } No newline at end of file | ||
|
|
||
| // Hook tất cả method trong class chứa "blank_ad_container" |
Comment on lines
+20
to
+25
| XposedBridge.hookMethod(method, object : de.robv.android.xposed.XC_MethodHook() { | ||
| override fun beforeHookedMethod(param: MethodHookParam) { | ||
| Logger.printDebug { "Hide Comment Ad - renderer blocked: ${method.name}" } | ||
| param.result = null | ||
| } | ||
| }) |
Owner
There was a problem hiding this comment.
Custom Xposed DSL is preferred in this project, Please ensure consistency in coding style across the entire repository.
| description = "Removes ads in the comments.",) { | ||
| description = "Removes ads in the comments.", | ||
| ) { | ||
| ::hideCommentAdsFingerprint.hookMethod { |
Owner
There was a problem hiding this comment.
Since you've hooked to nop all methods in the class containing this method, this seems redundant.
Comment on lines
+17
to
+24
| val adSponsoredContentFingerprint = findMethodDirect { | ||
| findMethod { | ||
| matcher { | ||
| returnType = "boolean" | ||
| strings("SponsoredContentController.insertItem") | ||
| } | ||
| }.single() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reddit: add hook to view renderer to hide ads placeholders in comments
Meta: hide ads in Reels and Story for Instagram