.github/templates: exclude cilium-cli-exclusive PRs from minor changelog - #421
Merged
Merged
Conversation
The minor release template is the only one that runs 2-prepare-release locally; the other templates route that step through the release workflow in cilium/cilium, which already passes --exclude-labels "cilium-cli-exclusive". Without the flag, a local run picks up PRs labeled cilium-cli-exclusive in the generated changelog, which then differs from what CI would have produced. Signed-off-by: André Martins <andre@cilium.io>
aanm
marked this pull request as ready for review
July 29, 2026 08:45
joestringer
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minor release template is the only one that runs
2-prepare-releaselocally. The other templates (
patch,pre_main,rc_branch) route thatstep through the release workflow in
cilium/cilium, which already passes--exclude-labels "cilium-cli-exclusive"on every./release startinvocation.
Without the flag, a local run of step 2 picks up PRs labeled
cilium-cli-exclusivein the generated changelog, so the output differs fromwhat CI would have produced for the same release.
Regenerated
testdata/checklist/release_template_minor.md.goldenviamake generate-golden. Only the minor golden changed — the.inputfiles aresymlinks to the real templates and only that one template was modified.