release-notes: Ignore "NONE" release note - #430
Merged
Conversation
We're frequently seeing contributors fail to read instructions and put a release note containing the text "NONE" in the release note section, similar to the rules style that Kubernetes expects. Rather than push a rock up a hill in convincing scores of new contributors to follow the pattern we expect, let's just ignore any release note that contains the text "NONE". Signed-off-by: Joe Stringer <joe@cilium.io>
aanm
approved these changes
Aug 27, 2026
| title: "Ketchup on pizza", | ||
| body: "```release-note\r\nNONE\n", | ||
| }, | ||
| want: "Ketchup on pizza", |
Member
There was a problem hiding this comment.
No, we don't want ketchup on pizza!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're frequently seeing contributors fail to read instructions and put a
release note containing the text "NONE" in the release note section,
similar to the rules style that Kubernetes expects. Rather than push a
rock up a hill in convincing scores of new contributors to follow the
pattern we expect, let's just ignore any release note that contains the
text "NONE".