fix: stop Set.All iteration when requested - #179
Merged
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
joamaki
reviewed
Aug 24, 2026
joamaki
left a comment
Contributor
There was a problem hiding this comment.
Oopsie! Thanks for the fix.
joamaki
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set.All()keeps yielding after a caller stops early.With 2 values, a normal
breakpanics withrange function continued iteration after function for loop body returned falseRepro:
Before this panics.
After this fix exits cleanly
The iterator now returns when
yieldis false, with a regression testTested with
make test,make test-race,make buildandmake bench