Skip to content

fix: close db watch change iterator on exit - #182

Merged
joamaki merged 1 commit into
cilium:mainfrom
immanuwell:fix-watchcmd-iterator-cleanup
Aug 25, 2026
Merged

fix: close db watch change iterator on exit#182
joamaki merged 1 commit into
cilium:mainfrom
immanuwell:fix-watchcmd-iterator-cleanup

Conversation

@immanuwell

@immanuwell immanuwell commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

A canceled db/watch leaves its deletion tracker registered.
That can keep deleted objects in the graveyard until runtime cleanup kicks in

This closes the change iterator when the command exits.
The test runs the real script command and checks the tracker returns to zero

Repro:

  1. Run the new test against main
  2. It fails because the tracker stays at 1
  3. Apply the fix, it returns to 0

Tested with make

Signed-off-by: immanuwell <pchpr.00@list.ru>
@immanuwell
immanuwell requested a review from a team as a code owner August 25, 2026 04:53
@immanuwell
immanuwell requested review from derailed and removed request for a team August 25, 2026 04:53
@joamaki
joamaki merged commit 197c5e6 into cilium:main Aug 25, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants