Skip to content

fix: handle HTTP query write errors - #192

Merged
joamaki merged 1 commit into
cilium:mainfrom
immanuwell:fix/http-query-write-errors
Aug 31, 2026
Merged

fix: handle HTTP query write errors#192
joamaki merged 1 commit into
cilium:mainfrom
immanuwell:fix/http-query-write-errors

Conversation

@immanuwell

@immanuwell immanuwell commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

HTTP query can panic after a client stops reading a streamed response

Return the write error and stop the query instead

Repro:

  1. Add the regression test
  2. Run go test ./ -run Test_http_query_write_error_does_not_panic -count=1
  3. On main it panics on a disconnected writer. This keeps it quiet

Tests: make test, make test-race

@immanuwell
immanuwell requested a review from a team as a code owner August 29, 2026 14:21
@immanuwell
immanuwell requested review from pippolo84 and removed request for a team August 29, 2026 14:21

@joamaki joamaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh why did I use panic there :D. Thanks for the fix.

@joamaki
joamaki merged commit 8b61300 into cilium:main Aug 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants