Skip to content

chore: Upgrade from ciscoconfparse to ciscoconfparse2#178

Open
mpenning wants to merge 1 commit into
cisco-en-programmability:mainfrom
mpenning:ciscoconfparse
Open

chore: Upgrade from ciscoconfparse to ciscoconfparse2#178
mpenning wants to merge 1 commit into
cisco-en-programmability:mainfrom
mpenning:ciscoconfparse

Conversation

@mpenning

@mpenning mpenning commented Mar 1, 2026

Copy link
Copy Markdown

Pull Request summary:

Upgrade to ciscoconfparse2 since ciscoconfparse` is now deprecated. See GitHub issue #118

Description of changes:

Upgrade was pretty simple; there was a small problem where some configs had a bunch of extra blank lines. This branch intentionally ignores blank lines.

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@mpenning

mpenning commented Mar 1, 2026

Copy link
Copy Markdown
Author

@sbasan please see this branch which has all necessary changes to migrate to ciscoconfparse2...

#178

@sbasan

sbasan commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

@mpenning Thank you for a patch! Looks like pyparsing dependency requires Python 3.9.
I think we should move with catalystwan and also drop 3.8 support with next release. Please give me some time to prepare adequate changes.

@mpenning

mpenning commented Mar 2, 2026

Copy link
Copy Markdown
Author

Looks like pyparsing dependency requires Python 3.9.

@sbasan I apologize, I have unit tests that tested for Python3.8 support in ciscoconfparse2 version 0.7.77... regardless, I defer to your needs... FWIW both Python 3.8 and 3.9 are declared End of Life by the PSF. However, it doesn't bother me if you keep using them.

@sbasan

sbasan commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

@mpenning I am aware of python EOL statuses.
We cannot drop 3.8 support as there are internal users still using python 3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants