Skip to content

fix(shared): improve single-session sign-in/sign-up dev warning wording#8488

Open
alexcarpenter wants to merge 2 commits intomainfrom
alex/sdk-66-single-session-warning-wording
Open

fix(shared): improve single-session sign-in/sign-up dev warning wording#8488
alexcarpenter wants to merge 2 commits intomainfrom
alex/sdk-66-single-session-warning-wording

Conversation

@alexcarpenter
Copy link
Copy Markdown
Member

Summary

  • The cannot_render_single_session_enabled dev warning previously used phrasing like "this is no-op" which made it look like something was broken
  • Reworded to clearly state this is expected behavior when a user is already signed in under single-session mode, and points developers to the Dashboard to enable multi-session if that's what they want
  • Before: The SignIn or SignUp modals do not render when a user is already signed in, unless the application allows multiple sessions. Since a user is signed in and this application only allows a single session, this is no-op.
  • After: The <SignIn/> and <SignUp/> modals are hidden because a user is already signed in and this application is configured for single-session mode. This is expected behavior — no action is needed. To allow rendering while signed in, enable multi-session mode in your Clerk Dashboard.

Ref: SDK-66

Test plan

  • Added warnings.test.ts verifying the warning contains key phrases ("expected behavior", "single-session mode", "multi-session mode", dev notice)
  • Verify in dev mode that the warning renders with the updated wording when triggering openSignIn/openSignUp while signed in

🤖 Generated with Claude Code

The `cannotOpenSignInOrSignUp` dev warning previously read as though
something was broken ("this is no-op"). Reword it to reassure
developers that the behavior is expected when a user is already signed
in under single-session mode, and point them to the Dashboard to enable
multi-session if needed.

Ref: SDK-66

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 6, 2026 2:56pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2026

🦋 Changeset detected

Latest commit: 68033c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@clerk/shared Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/expo-passkeys Patch
@clerk/expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/hono Patch
@clerk/localizations Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/react Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 26d5eae7-757d-4891-8fd7-dd120d5b78da

📥 Commits

Reviewing files that changed from the base of the PR and between 8976922 and 68033c5.

📒 Files selected for processing (1)
  • .changeset/single-session-warning-wording.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/single-session-warning-wording.md

📝 Walkthrough

Walkthrough

This PR adds a Vitest test file that asserts the cannotOpenSignInOrSignUp warning includes the phrases "expected behavior", "single-session mode", "multi-session mode", and a development notice. It also updates the cannotOpenSignInOrSignUp warning string in warnings.ts to reference single-session mode behavior and direct developers toward enabling multi-session mode. A changeset patch file documenting the wording change was added.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: improving the wording of a developer warning for single-session mode sign-in/sign-up scenarios.
Description check ✅ Passed The description is directly related to the changeset, providing clear before/after comparisons and explaining why the wording was changed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Microsoft Presidio Analyzer (2.2.362)
.changeset/single-session-warning-wording.md

Microsoft Presidio Analyzer failed to scan this file


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8488

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8488

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8488

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8488

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8488

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8488

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8488

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8488

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8488

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8488

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8488

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8488

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8488

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8488

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8488

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8488

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8488

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8488

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8488

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8488

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8488

commit: 68033c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants