[2.0 Breaking] Sender changes for C# modules
#4143
Merged
+155
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/sender-changes-for-csharp
branch
from
9a33fa2 to
c1049ac
Compare
Collaborator
Author
|
/update-llm-benchmark |
joshua-spacetime
changed the title
Sender changes for C# modules
Collaborator
Author
|
/update-llm-benchmark |
3 similar comments
Collaborator
|
/update-llm-benchmark |
Collaborator
|
/update-llm-benchmark |
Collaborator
|
/update-llm-benchmark |
jdetter
force-pushed
the
joshua/sender-changes-for-csharp
branch
from
aed4952 to
4eadeb7
Compare
joshua-spacetime
force-pushed
the
joshua/sender-changes-for-csharp
branch
from
4eadeb7 to
1ea1cae
Compare
joshua-spacetime
force-pushed
the
joshua/sender-changes-for-csharp
branch
from
1ea1cae to
112f2b7
Compare
rekhoff
approved these changes
Jan 28, 2026
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
Converting Sender to a method makes a lot of sense for encapsulation reasons. No objection as this is tagged for 2.0 so the breaking change is fine. Tested locally and confirm these changes build. Approved.
joshua-spacetime
merged commit 5831494
into
2.0-breaking-changes
21 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Make
Sendera method on [Reducer|View|Procedure|Tx]Context in C#. Equivalent changes to #4101.API and ABI breaking changes
API breaking
Expected complexity level and risk
1
Testing
Pure refactor, no additional testing.