Add a browser-runtime shadow-cljs integration test - #61
Merged
Conversation
bbatsov
force-pushed
the
browser-runtime-integration-test
branch
from
July 18, 2026 09:37
3fb45e0 to
f42fad4
Compare
Our only integration coverage ran over a Node runtime, so the browser completion path (issues #47 and #48) was untested. This adds a :browser-test shadow build served over :dev-http and loaded in headless Chrome, so a real browser runtime connects back and we can drive completions against it. The test confirms `(.lo js/console)` method completion works over a browser runtime on a plain clone, which pins #47/#48 to mranderson inlining rather than the browser path itself. It skips cleanly when no Chrome binary is found, so it stays green where a browser isn't available.
bbatsov
force-pushed
the
browser-runtime-integration-test
branch
from
July 18, 2026 09:42
f42fad4 to
a586ecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our shadow-cljs integration coverage only ran over a Node runtime, so the browser completion path in #47 and #48 was never actually exercised. This spins up a
:browser-testshadow build, serves it via:dev-http, and loads it in headless Chrome so a real browser runtime connects back and we can drive completions against it.The payoff: it confirms
(.lo js/console)method completion works fine over a browser runtime on a plain clone. That pins #47/#48 to mranderson inlining (the inlined introspection namespace not loading in the browser), not the browser path itself - and gives us a rig to chase the actual fix on.The test self-skips when no Chrome binary is found (override with
SUITABLE_CHROME_BIN), so it stays green where a browser isn't available. ubuntu-latest ships Chrome, so it runs in CI.Refs #47, #48.