feat!: Bump terraform required_version to >= 1.5.7 and AWS provider to >= 6#110
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the module’s minimum supported Terraform and AWS provider versions (Terraform >= 1.5.7 and AWS provider >= 6) and refreshes local/CI developer tooling to match the new baseline (mise lockfile, pre-commit hooks, and trivy config).
Changes:
- Bump Terraform required_version to
>= 1.5.7, < 2.0and AWS provider to>= 6, < 7(including README + examples docs refresh). - Rework dev tooling to be mise-driven (lockfile enabled, pinned tool versions, terraform-docs task script).
- Add local pre-commit security scanning via
trivy config(with CI pre-commit job skipping that hook).
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
trivy.yaml |
Adds Trivy configuration (skip dirs) for local trivy config scans. |
terraform.tf |
Updates Terraform and AWS provider version constraints for the root module. |
README.md |
Regenerates requirements/provider tables to reflect new minimum versions. |
mise.toml |
Enables mise lockfile and pins/expands toolchain (python, terraform-docs, tflint, trivy, etc.). |
mise.lock |
Adds generated lockfile pinning exact tool versions and download metadata. |
mise-tasks/terraform-docs.sh |
Introduces a mise task to run terraform-docs across root + examples (+ modules if present). |
examples/multiple-runners/terraform.tf |
Updates example Terraform minimum version. |
examples/multiple-runners/README.md |
Regenerates example requirements table to reflect new Terraform minimum. |
examples/basic/terraform.tf |
Updates example Terraform minimum version. |
examples/basic/README.md |
Regenerates example requirements table to reflect new Terraform minimum. |
examples/basic-org/terraform.tf |
Updates example Terraform minimum version. |
examples/basic-org/README.md |
Regenerates example requirements table to reflect new Terraform minimum. |
examples/advanced/terraform.tf |
Updates example Terraform minimum version. |
examples/advanced/README.md |
Regenerates example requirements table to reflect new Terraform minimum. |
examples/addition-iam-policies/terraform.tf |
Updates example Terraform minimum version. |
examples/addition-iam-policies/README.md |
Regenerates example requirements table to reflect new Terraform minimum. |
Dockerfile |
Switches devcontainer base image reference to the newer mcr.microsoft.com/devcontainers/... image format. |
.pre-commit-config.yaml |
Updates hook versions and migrates shfmt/shellcheck/terraform-docs/trivy scanning to local system hooks (mise-backed). |
.github/workflows/pre-commit-and-tests.yml |
Skips the trivy-config hook in CI pre-commit runs via SKIP. |
.flake8 |
Removes flake8 configuration (tooling appears to be moving to ruff-only). |
.devcontainer/devcontainer.json |
Updates devcontainer build args to match the Dockerfile’s new IMAGE argument. |
Comments suppressed due to low confidence (1)
terraform.tf:8
- With the AWS provider minimum bumped to v6, the module currently still references
data.aws_region.current.name(e.g.,locals.tfandexamples/addition-iam-policies/iam.tf). In AWS provider v6 this attribute is deprecated (see #109); switch those references todata.aws_region.current.regionto avoid deprecation warnings (and future breakage).
| jq = "latest" | ||
| node = "latest" | ||
| pre-commit = "latest" | ||
| python = "3.13" # For pre-commit |
Contributor
Author
There was a problem hiding this comment.
Fair point, I'll patch this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Required for #109
Type of Change
Changes Made
Per description
Testing
None
Breaking Changes
Terraform version and AWS provider version is updated.
These have been out for a long time now, users of this module are expected to update their software accordingly.
Notes
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.