fix(tokio-quiche): avoid u128 transmute for Instant zero - #2533
Open
Parikalp-Bhardwaj wants to merge 2 commits into
Open
fix(tokio-quiche): avoid u128 transmute for Instant zero#2533Parikalp-Bhardwaj wants to merge 2 commits into
Parikalp-Bhardwaj wants to merge 2 commits into
Conversation
ghedo
force-pushed
the
fix-i686-instant-zero
branch
from
July 18, 2026 09:35
8e8cb75 to
23e6ba1
Compare
antoniovicente
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the
i686-unknown-linux-gnubuild failure caused by transmuting0u128intostd::time::Instant.On i686,
Instantis 96 bits whileu128is 128 bits, so the transmute fails with E0512/E0080.The fix uses
std::mem::zeroed::<Instant>()instead, which avoids assuming a fixedInstantsize across targets.Fixes #2505