fix(build): externalize Next server packages#2100
Open
NathanDrake2406 wants to merge 1 commit into
Open
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serverExternalPackagesplus userssr.externalentries.prerender-native-modulePages Router behavior with a local sqlite/sqlite3 fixture that proves nativesqlite3stays external and that prerendered/fallback routes render the same props contract.Root Cause
Vinext forced most Node server dependencies through Vite with
noExternal: true, only letting React andipaddr.jsescape in plain Pages Router builds. Packages likesqlite3therefore got bundled into the ESM server entry, where CommonJS/native-loader code can retain__dirnameand crash during build-time prerendering.Next.js keeps a predefined server external package list and combines it with user
serverExternalPackages; packages on that effective list are loaded natively instead of bundled.References
serverExternalPackages: packages/next/src/build/webpack-config.tsVerification
vp test run tests/build-optimization.test.ts --project unit -t "server packages"vp test run tests/nextjs-compat/prerender-native-module.test.ts --project integrationvp check packages/vinext/src/index.ts packages/vinext/src/config/server-external-packages.ts tests/build-optimization.test.ts tests/nextjs-compat/prerender-native-module.test.tsvp env exec --node 24 ./scripts/run-nextjs-deploy-suite.sh /Users/nathan/Projects/vinext/.refs/nextjs-v16.2.6 --retries 0 -c 1 --debug test/e2e/prerender-native-module.test.tsPre-commit also ran staged checks, full check, staged unit/integration tests, and knip successfully.