Skip to content

Comments

[merge] Add ZSTD bindings to the node:zlib package.#6117

Merged
npaun merged 1 commit intomainfrom
npaun/merge-zstd
Feb 19, 2026
Merged

[merge] Add ZSTD bindings to the node:zlib package.#6117
npaun merged 1 commit intomainfrom
npaun/merge-zstd

Conversation

@npaun
Copy link
Member

@npaun npaun commented Feb 19, 2026

This PR is created to merge #6007

@npaun npaun requested a review from anonrig February 19, 2026 19:03
@npaun npaun requested review from a team as code owners February 19, 2026 19:03
@npaun npaun enabled auto-merge (squash) February 19, 2026 19:05
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 19, 2026

Merging this PR will degrade performance by 16.15%

❌ 1 regressed benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
jsonResponse[Response] 39.8 µs 47.4 µs -16.15%

Comparing npaun/merge-zstd (5716286) with main (fcf3784)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 54.09091% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.65%. Comparing base (fcf3784) to head (5716286).

Files with missing lines Patch % Lines
src/workerd/api/node/zlib-util.c++ 53.48% 78 Missing and 22 partials ⚠️
src/workerd/api/node/zlib-util.h 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6117      +/-   ##
==========================================
- Coverage   70.67%   70.65%   -0.02%     
==========================================
  Files         409      409              
  Lines      109232   109452     +220     
  Branches    18031    18066      +35     
==========================================
+ Hits        77199    77335     +136     
- Misses      21215    21279      +64     
- Partials    10818    10838      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@npaun npaun merged commit adcc762 into main Feb 19, 2026
22 of 23 checks passed
@npaun npaun deleted the npaun/merge-zstd branch February 19, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants