Skip to content

Conversation

@marckhouzam
Copy link
Contributor

@marckhouzam marckhouzam commented Nov 14, 2025

Description of the Change

Missing space-role "SpaceSupporter" in the completion choices.
This was forgotten in #2176

Why Is This PR Valuable?

Helps the users that use shell completion for the set-space-role and unset-space-role.

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Not urgent

Manual testing

$ cat ~/cf.zsh
# zsh completion for Cloud Foundry CLI

_cf-cli() {
    # All arguments except the first one
    args=("${COMP_WORDS[@]:1:$COMP_CWORD}")
    # Only split on newlines
    local IFS=$'\n'
    # Call completion (note that the first element of COMP_WORDS is
    # the executable itself)
    COMPREPLY=($(GO_FLAGS_COMPLETION=1 ${COMP_WORDS[0]} "${args[@]}"))
    return 0
}
autoload -U +X bashcompinit && bashcompinit
complete -F _cf-cli cf

$ source ~/cf.zsh

$ out/cf set-space-role [email protected] cli-org SP1 Space<TAB>
SpaceAuditor    SpaceDeveloper  SpaceManager    SpaceSupporter

@marckhouzam marckhouzam force-pushed the marck/fixSpaceRoleComp branch from caf379e to b21a653 Compare November 14, 2025 15:28
Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gururajsh gururajsh merged commit 7ea11c1 into cloudfoundry:v8 Nov 18, 2025
14 of 15 checks passed
@marckhouzam marckhouzam deleted the marck/fixSpaceRoleComp branch November 18, 2025 19:23
marckhouzam added a commit to marckhouzam/cf-cli that referenced this pull request Nov 18, 2025
marckhouzam added a commit to marckhouzam/cf-cli that referenced this pull request Nov 18, 2025
marckhouzam added a commit to marckhouzam/cf-cli that referenced this pull request Nov 19, 2025
marckhouzam added a commit to marckhouzam/cf-cli that referenced this pull request Nov 20, 2025
marckhouzam added a commit to marckhouzam/cf-cli that referenced this pull request Dec 10, 2025
gururajsh pushed a commit that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants