Skip to content

fix: cloudfoundry_app and cloudfoundry_apps datasource does not return instances attribute#544

Merged
lechnerc77 merged 1 commit into
mainfrom
issue-472
Jul 8, 2026
Merged

fix: cloudfoundry_app and cloudfoundry_apps datasource does not return instances attribute#544
lechnerc77 merged 1 commit into
mainfrom
issue-472

Conversation

@ANUGRAHG

@ANUGRAHG ANUGRAHG commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Purpose

  • This PR fixes an issue where top-level process attributes in the cloudfoundry_app and cloudfoundry_apps data sources were always returned as null.
  • The cloudfoundry_app and cloudfoundry_apps data sources expose top-level attributes from the web process (e.g. instances, memory, disk_quota, health_check_type, command, etc.) via datasourceProcessAppCommonSchema()
  • Although these attributes were defined in the schema, they were never populated from the corresponding web process, causing them to always return null.
  • Now, after populating each Process struct in the loop, the web process fields are copied to the matching top-level fields on DatasourceAppType.
  • closes [BUG] Data Source for cloudfoundry app and cloudfoundry apps does not retun values in attribute instances #472

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@github-actions github-actions Bot added this to the 1.15.0 milestone Jul 1, 2026
@github-actions github-actions Bot added the bug Something isn't working label Jul 1, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@lechnerc77 lechnerc77 enabled auto-merge (squash) July 1, 2026 09:58
@lechnerc77 lechnerc77 modified the milestones: 1.15.0, 1.17.0 Jul 1, 2026
@lechnerc77 lechnerc77 merged commit e53efee into main Jul 8, 2026
14 checks passed
@lechnerc77 lechnerc77 deleted the issue-472 branch July 8, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Data Source for cloudfoundry app and cloudfoundry apps does not retun values in attribute instances

2 participants