router: initial implementation by mweibel · Pull Request #148 · cloudscale-ch/terraform-provider-cloudscale

mweibel · 2026-07-24T13:12:55Z

No description provided.

mweibel · 2026-08-03T13:55:28Z

 	google.golang.org/protobuf v1.36.11 // indirect
 )
+
+replace github.com/cloudscale-ch/cloudscale-go-sdk/v9 => ../cloudscale-go-sdk


⚠️ remove before trying to merge

alakae · 2026-08-07T14:57:31Z

+In addition to the arguments listed above, the following computed attributes are exported:
+
+* `href` - The cloudscale.ch API URL of the current router.
+* `tags` - The tags assigned to this router.


items already listed in ## Argument Reference should not be repeated here. applies to: tags and internet_gateway.

alakae · 2026-08-07T15:00:44Z

+
+* `id` - (Optional) The UUID of a router.
+* `name` - (Optional) The name of a router.
+* `zone_slug` - (Optional) The zone slug of a router. Options include `lpg1` and `rma1`.


should be listed here, not in attributes:

* `tags` - (Optional) Filter by tags; the resource must have at least the specified key-value pairs (subset match).

nice catch, done.

alakae · 2026-08-07T15:01:33Z

+In addition to the arguments listed above, the following computed attributes are exported:
+
+* `href` - The cloudscale.ch API URL of the current router.
+* `tags` - The tags assigned to this router.


similarly, this goes I way I guess :)

indeed ;) done.

alakae · 2026-08-07T15:03:23Z


 *Remember to replace `[your-username]` with your actual username.*

+### Debugging with Delve


out of curiosity: why did you need this? for me it worked pretty good to debug the provider using the integration tests.

I don't remember exactly which part I needed to debug, but in general, I personally often prefer to debug using a debugger to be able to inspect what variables etc. hold in specific breakpoints.

Yes; me to. What i meant: the intellij debugger can attach to the tests without additional tooling.

ah.. yeah that's true. Not sure why I didn't do it that way to be honest..

alakae · 2026-08-07T15:17:29Z

+					resource.TestCheckResourceAttr(
+						resourceName, "addresses.#", "1"),
+					resource.TestCheckResourceAttrSet(
+						resourceName, "addresses.0.address"),


please try to assert all attributes, imho network_name, network_href and type are not asserted.

alakae · 2026-08-07T15:28:35Z

+
+func gatherRouterUpdateRequest(d *schema.ResourceData) []*cloudscale.RouterUpdateRequest {
+	requests := make([]*cloudscale.RouterUpdateRequest, 0)
+	// FIXME: not implemented yet


nit: delete this?

you mean the FIXME comment or the whole gatherRouterUpdateRequest function?

removed it, along with all commented-out code.

alakae · 2026-08-10T10:08:22Z

+			Optional: true,
+			Computed: true,


The upstream API always requires an address on an interface. There is no auto-assign (contrary to server interfaces).

I think this should read:

Required: true,

Also adjust the docs to reflect this.

also maybe its worth the double check this is correct in the go-sdk

fixed, thanks. SDK is not a problem.

- config.go: use context.Background() and NewSubsystemLoggingHTTPTransport - gofmt/whitespace fixes in floating_ip datasource, volume test, provider test

Adds cloudscale_router (resource + data source) and cloudscale_interface, plus a load-balancer health-monitor URLPath rename (due to lint). Additionally: - splitImportID: moved to util.go and parameterized so import errors name the correct attributes (router_uuid/interface_uuid vs pool_uuid/member_uuid)

- updates docs with attributes/arguments - adds missing assertions - corrects interface create computed/required/optional flags - remove waitForDeleted: router/interface delete are now both synchronously deleted

mweibel force-pushed the mweibel/router branch 3 times, most recently from a6ba7c4 to 51e9444 Compare July 27, 2026 08:06

Base automatically changed from alain/lb-operations-mux to master July 27, 2026 13:12

mweibel force-pushed the mweibel/router branch from 51e9444 to 4742d8c Compare August 3, 2026 13:33

mweibel commented Aug 3, 2026

View reviewed changes

Comment thread cloudscale/resource_cloudscale_interface.go

mweibel commented Aug 3, 2026

View reviewed changes

mweibel force-pushed the mweibel/router branch 2 times, most recently from cfe208b to 80e7c38 Compare August 5, 2026 14:46

alakae reviewed Aug 7, 2026

View reviewed changes

alakae reviewed Aug 10, 2026

View reviewed changes

mweibel force-pushed the mweibel/router branch from 3ed2604 to 39dc956 Compare August 12, 2026 11:16

mweibel added 3 commits August 12, 2026 13:18

chore: gofmt and HTTP logging/oauth cleanups

5641d90

- config.go: use context.Background() and NewSubsystemLoggingHTTPTransport - gofmt/whitespace fixes in floating_ip datasource, volume test, provider test

fix: delete interfaces before deleting routers

c70966c

mweibel force-pushed the mweibel/router branch from 39dc956 to a4b2c3e Compare August 12, 2026 11:18

mweibel added 2 commits August 12, 2026 13:22

address review comments & backend changes

5a845a0

- updates docs with attributes/arguments - adds missing assertions - corrects interface create computed/required/optional flags - remove waitForDeleted: router/interface delete are now both synchronously deleted

chore: add debug instructions and setup

2679936

mweibel force-pushed the mweibel/router branch from a4b2c3e to 2679936 Compare August 12, 2026 11:22


		Remember to replace `[your-username]` with your actual username.

		### Debugging with Delve

Uh oh!

Conversation

mweibel commented Jul 24, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants