refactor: use pre-created Set for modifier key lookup in isModifierKey#188
Open
TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
Open
refactor: use pre-created Set for modifier key lookup in isModifierKey#188TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
Conversation
Replace inline array creation with a pre-created Set for O(1) lookup. This eliminates array allocation on every keydown event. Before: return [KeyCode.shift, KeyCode.alt, KeyCode.control, KeyCode.meta].includes(event.keyCode); After: const modifierKeyCodes = new Set([KeyCode.shift, KeyCode.alt, KeyCode.control, KeyCode.meta]); return modifierKeyCodes.has(event.keyCode); This is significant because isModifierKey is called on every keydown event via the focus-visible module's handleKeydown handler.
avinashbot
approved these changes
Jan 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 42 42
Lines 1101 1102 +1
Branches 280 293 +13
=======================================
+ Hits 1090 1091 +1
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the inline array creation in
isModifierKeywith a pre-createdSetfor O(1) lookup, eliminating array allocation on every function call.Motivation
The
isModifierKeyfunction is called on everykeydownevent via thefocus-visiblemodule'shandleKeydownhandler. The previous implementation created a new array on every call:This means every keypress triggered:
.includes()This could contribute to typing feeling sluggish.
Changes
src/internal/keycode.ts: Create the Set once at module load time and useSet.has()for O(1) lookup:Benefits
Testing
All 17 focus-visible tests pass, including tests for each modifier key (Shift, Alt, Control, Meta).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.