Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Jan 27, 2026

Description

Introduces suppressible flag to error boundaries. Now, when a boundary is used with suppressNested=true, only suppressible standalone error boundaries will get disabled.

See: [kmVcAbjoeQB4]

How has this been tested?

  • New unit tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.17%. Comparing base (6a5486b) to head (b1607c1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4211      +/-   ##
==========================================
+ Coverage   97.16%   97.17%   +0.01%     
==========================================
  Files         879      882       +3     
  Lines       25780    25826      +46     
  Branches     9328     9332       +4     
==========================================
+ Hits        25049    25097      +48     
+ Misses        725      723       -2     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot marked this pull request as ready for review January 27, 2026 11:23
@pan-kot pan-kot requested a review from a team as a code owner January 27, 2026 11:23
@pan-kot pan-kot requested review from YueyingLu and removed request for a team January 27, 2026 11:23
* When `suppressNested` is set to `true`, nested built-in or standalone
* boundaries are disabled. In this mode, all errors originating from within
* the boundary’s content are captured exclusively by this boundary.
* When `suppressNested` is set to `true`, nested built-in error boundaries,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: I'd suppress the comma after the first line, and replace "or" with "and" in the second one, since this will affect both built-in error boundaries and nested standalone error boundaries, not one or the other:

When suppressNested is set to true, nested built-in error boundaries and nested standalone error boundaries with suppressible=true are disabled, so the errors propagate further up and are captured by this error boundary.

gethinwebster
gethinwebster previously approved these changes Jan 28, 2026
@pan-kot pan-kot added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit cee57ab Jan 28, 2026
49 checks passed
@pan-kot pan-kot deleted the error-boundary-supressible branch January 28, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants