Conversation
cdap-e2e-tests/src/e2e-test/features/controlcenter/ControlCenter.feature
Show resolved
Hide resolved
| Then Close the pipeline logs | ||
| Then Click on the Hamburger bar on the left panel | ||
| Then Click on Control Center link from the hamburger menu | ||
| Then Verify the pipeline created by add button is succeeded successfully and is present in control center page |
There was a problem hiding this comment.
Change it to "Verify the pipeline created successfully is present in control center page"
There was a problem hiding this comment.
Changed to Verify the pipeline created successfully is present in control center page
cdap-e2e-tests/src/e2e-test/features/controlcenter/ControlCenter.feature
Show resolved
Hide resolved
There was a problem hiding this comment.
All attributes should be control center related , Same in case of error message and pluginParam . Change if there is any common key value pair in all 4 modules which can be user as generic
There was a problem hiding this comment.
ok all the attributes are contol center related
| @RunWith(Cucumber.class) | ||
| @CucumberOptions( | ||
| features = {"src/e2e-test/features"}, | ||
| glue = {"io.cdap.cdap.controlcenter.stepsdesign", "stepsdesign", "io.cdap.plugin.bigquery.stepsdesign"}, |
There was a problem hiding this comment.
Why is BigQuery glue added? please remove
There was a problem hiding this comment.
removed the glue
| public static String bqSourceTable = StringUtils.EMPTY; | ||
| public static String datasetName = PluginPropertyUtils.pluginProp("dataset"); | ||
|
|
||
| @Before(order=1 ,value = "@BQ_INSERT_INT_SOURCE_TEST") |
There was a problem hiding this comment.
Add the after hook for this before hook.
There was a problem hiding this comment.
added the hook
|
|
||
| @Before(order=1 ,value = "@BQ_INSERT_INT_SOURCE_TEST") | ||
| public static void createSourceBQTable() throws IOException, InterruptedException { | ||
| bqSourceTable = "E2E_TARGET_" + UUID.randomUUID().toString().replaceAll("-", "_"); |
There was a problem hiding this comment.
This should be source table right?
There was a problem hiding this comment.
CHANGED TO source
| serverUrl=https://placeholder.com/api | ||
| # command to generate token: gcloud auth print-access-token | ||
| serverAccessToken=placeholder | ||
| bqSourceTable=dummy |
There was a problem hiding this comment.
Add start and end comments for control center feature
There was a problem hiding this comment.
Added the comments
priyabhatnagar25
force-pushed
the
controlcenter_e2e
branch
3 times, most recently
from
6570b17 to
0df4133
Compare
priyabhatnagar25
force-pushed
the
controlcenter_e2e
branch
from
0df4133 to
5c8ac3e
Compare
3 participants
ControlCenter cdap-feature file