Add dictionary param support to resources that have AWSHelperFn props.#957
Open
LyndonHook wants to merge 2 commits intocloudtools:mainfrom
Open
Add dictionary param support to resources that have AWSHelperFn props.#957LyndonHook wants to merge 2 commits intocloudtools:mainfrom
LyndonHook wants to merge 2 commits intocloudtools:mainfrom
Conversation
Author
|
Any feedback on this? I'd love to get it merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dictionary parameter support for resources that use AWSHelperFn objects as properties. The resources can then be instantiated by using a python dictionary type instead of having to pass the actual helper function object. Its necessary if your resource creation is driven by YAML config.
e.g.
YAML -> Dictionary -> Troposphere Resource