Skip to content

[CLOUDTRUST-8719] Add an endpoint to delete an extidp team member#97

Merged
basbeu merged 2 commits into
masterfrom
CLOUDTRUST-8719
Jun 26, 2026
Merged

[CLOUDTRUST-8719] Add an endpoint to delete an extidp team member#97
basbeu merged 2 commits into
masterfrom
CLOUDTRUST-8719

Conversation

@basbeu

@basbeu basbeu commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@basbeu basbeu marked this pull request as ready for review June 11, 2026 14:54
import jakarta.ws.rs.POST;
import jakarta.ws.rs.PUT;
import jakarta.ws.rs.Path;
import jakarta.ws.rs.PathParam;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added but not used... I guess this is an error?

return new CtIdpRealmsResource(auth, session);
}

private AdminAuth authenticateRealmAdminRequest(HttpHeaders headers) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we already have tools for this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, however we already have the exact same function in the admin API, that's why I will put this elsewhere in a shared file

@Xelowak Xelowak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I could reuse some code that was already written for the admin API to reduce duplication, what do you think?

@basbeu basbeu merged commit d55e476 into master Jun 26, 2026
3 checks passed
@basbeu basbeu deleted the CLOUDTRUST-8719 branch June 26, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants